Detect password protected xls files #386
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #385. It looks like Protect record that is currently used for password protected files detection may not be the best option. There are two reasons:
this property may signify another kind of protection but not necessarily the password one.
I've noticed that some libraries are trying to detect "FilePass" instead and it works better for problematic files that we have.
I was not able to determine if it is necessary to keep logic related to "Protect" record in place (my changes do not break any tests), please suggest if we need to keep it.